Allows downstream users to opt out of onig and use fancy-regex instead #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| Hey @huevosabio, thanks for taking the time to make this PR, LGTM! Will try to release this later today. |
Member
| @huevosabio this is now released; if you use the latest version (https://crates.io/crates/model2vec-rs/0.1.3), you can use the fancy-regex feature when configuring your dependency. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Allows downstream users to opt out of onig and use fancy-regex instead
We were running into nasty segfault issues when trying to link model2vec-rs with C# bindings on Linux and it turns out it was some sort of issue with
onigdependency on tokenizers.This allows us to bypass that and use the rust-only
fancy-regexcrate.