Skip to content
This repository was archived by the owner on May 13, 2025. It is now read-only.

Villager trading #37

Merged
merged 13 commits into from
Jun 4, 2022
Merged

Villager trading #37

merged 13 commits into from
Jun 4, 2022

Conversation

@dealingwith
Copy link
Member

@dealingwith dealingwith commented May 8, 2022 •
edited by jamespeilunli
Loading

closes #33
@dealingwith dealingwith changed the title initial trading page Villager trading May 8, 2022
@dealingwith
Copy link
Member Author

dealingwith commented May 8, 2022

https://minecraft.fandom.com/wiki/Villager
@jamespeilunli
Copy link
Contributor

jamespeilunli commented May 30, 2022

I added a few potential trading images you might want to use (feel free to make your own though). I also added fletcher images, because I think we should note that the fletcher is a good source of emeralds (traded from sticks).
@dealingwith
Copy link
Member Author

dealingwith commented May 31, 2022

Thank you @jamespeilunli!
@dealingwith dealingwith marked this pull request as ready for review May 31, 2022 03:58
@dealingwith dealingwith requested a review from jamespeilunli May 31, 2022 03:58
@dealingwith
Copy link
Member Author

dealingwith commented May 31, 2022

@jamespeilunli what else do you think is needed here? I think we decided this PR needs to go in first so you can slot your module in wherever it needs to go. (Because this one already renames a bunch of modules.)
@jamespeilunli
Copy link
Contributor

jamespeilunli commented May 31, 2022 •
edited
Loading

I think we should give a brief description of what villagers are, where they are found, and their behavior (e.g. job block behavior; see wiki), perhaps at the very start in a single paragraph (we can put types of villagers under a ##). I'll try to work on this as soon as I can.
jamespeilunli
jamespeilunli reviewed Jun 4, 2022
View reviewed changes
Copy link
Contributor

@jamespeilunli jamespeilunli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I want you to review my changes.
@dealingwith dealingwith merged commit 90b126e into main Jun 4, 2022
@dealingwith dealingwith deleted the 33-trading branch June 4, 2022 20:15
@dealingwith dealingwith mentioned this pull request Jun 4, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@dealingwith @jamespeilunli