Changed packRow() to work in bytes not words #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
this is proposed to fix an odd edge-case where the hex code does not start on a word boundry. Unfortunately I lack the means to test this.
| I made the change against the master branch as there was only one packRow to change in master. The refactoring branch has multiple "packrows". Also I must stress I don't have hardware to run this on, the "cast" to uint8_t came from Googling. I considered changing the type of "row[]" but that would have had loads of side effects. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
this is proposed to fix an odd edge-case where the hex code does
not start on a word boundry. Unfortunately I lack the means to test this.