Feat: add support for graphql@16.x.x #1383
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
For more informations, please refer to: graphql/graphql-js#2900
GeoffreyHervet commented Nov 18, 2022
Comment on lines +117 to +121
| const { errors } = await graphql({ | ||
| schema, | ||
| source: getIntrospectionQuery(), | ||
| }); | ||
| |
Author
There was a problem hiding this comment.
No breaking change, compatible with graphql@15.x.x
https://github.com/graphql/graphql-js/blob/15.x.x/src/graphql.d.ts#L54-L64
Owner
| We already have support for that in |
Author
| yes, but the v2 is still in beta, not stable :( |
Owner
| Sorry but I'm not gonna merge this and release as minor release. I don't have resources to maintain two parallel versions. The upgrade is done and will be released with all the other changes from |
MichalLytek added Wontfix ❌ Author
| @MichalLytek when will you merge #1331 ? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add support for graphql@16.x.x
The only BreakingChange is removing support for long deprecated comments as descriptions
graphql/graphql-js#2900