Fix power connectors again #419
Draft
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Goal
Fixes #99 again, update of #278.
What was the problem ?
Power connectors were not balanced because :
W
Solution
dummy
potential variable in connectorsImplementation
dummy
variable is created in power inlet and outlet connectorsdummy
variable of power connectors is set as a connector inputdummy
of this connector, so I just added a power sink in the SG, and sincedummy=0
is defined in the sink, it defines it into the connection set there.Warnings
Note that this is a bit weird and not super flexible/robust because you could be willing to connect some power components that would both try to set the
dummy
variable, resulting in an over constrained model.But it shouldn't be a problem (as of now), because we should never face this issue, because we would probably never have a single connection set with several generators/power sensors/power sinks, etc.
Type of change
package.mo
)Will it break anything in previous models ?
Checklist
You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.