Tree sequence #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
petrelharp reviewed Feb 25, 2018
core/slim_sim.cpp Outdated
| | ||
| simplifier_free(&simplifier); | ||
| | ||
| FSIDAS = (int)((CurrentTreeSequenceIndividual->PedigreeID()) * 2) + 2; |
Collaborator
There was a problem hiding this comment.
Checking I understand: This implies that CurrentTreeSequenceIndividual is going to be the next individual born, no? It hasn't already been born? That doesn't sound "Current"?
Contributor Author
There was a problem hiding this comment.
the +2 implies that it will be the next one generated. (CurrentTreeSequenceIndividual->PedigreeID() * 2) +1 should have been the last genome generated before the SimplifyTables() gets called.
petrelharp force-pushed the treeSequence branch from 3bfd25c to 0ffc8d4 Compare 
petrelharp force-pushed the treeSequence branch from 5c3d9c7 to 844a600 Compare petrelharp force-pushed the treeSequence branch from 509afed to 43b09b4 Compare Merge branch 'treeSequence' of https://github.com/jgallowa07/SLiM into treeSequence
Merge branch 'treeSequence' of https://github.com/jgallowa07/SLiM into treeSequence
Merge branch 'treeSequence' of https://github.com/jgallowa07/SLiM into treeSequence
Collaborator
| 🎆 <- that's "fireworks" |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Still under construction. just wanted to post this for discussion sake