Skip to content

Conversation

rocky
Copy link
Member

@rocky rocky commented Feb 23, 2023

These were the few only remaining things I found. After this I think we should merge split_main into master.

@rocky rocky requested a review from mmatera February 23, 2023 22:46
Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatera
Copy link
Contributor

mmatera commented Feb 23, 2023

Let's merge this, and then the other branch

@mmatera mmatera merged commit f3f8c41 into split_main Feb 23, 2023
@mmatera mmatera deleted the final-push branch February 23, 2023 22:50
@mmatera
Copy link
Contributor

mmatera commented Feb 23, 2023

BTW, thank you very much @rocky for the fixes and revision.

@rocky
Copy link
Member Author

rocky commented Feb 23, 2023

And thank you for doing the bulk of the hard work. With this in, I think we finally ready for the 6.0.0 release this weekend. (Early Saturday I'll be working with @TiagoCavalcante to see if we can address why we can't use the most recent mathics-threejs-backend. If there is a change needed to mathics-core, we should be able to slip that in.)

Whew!

@rocky
Copy link
Member Author

rocky commented Feb 23, 2023

Let's merge this, and then the other branch

Yes, absolutely - thanks!

rocky added a commit that referenced this pull request Feb 23, 2023
* split main in modules * adding comments * black * fix summaries * rocky's comments fixed * black * test for wordlist * easy fixes * complete doctests * fix Containing. Adding test cases * black * trailing typos * split nltk from utils * Some small tweaks and conformance things (#15) --------- Co-authored-by: R. Bernstein <rocky@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants