Skip to content

Conversation

rocky
Copy link
Member

@rocky rocky commented Feb 20, 2023

for now. init.py "library" -> Python library

for now. __init__.py "library" -> Python library
@TiagoCavalcante
Copy link
Contributor

Why remove this?

@mmatera
Copy link
Contributor

mmatera commented Feb 20, 2023

Why remove this?

The implementation is wrong. Maybe it would be enough to comment out the eval method, and the symbol in init.py

@rocky
Copy link
Member Author

rocky commented Feb 20, 2023

Why remove this?

The implementation is wrong. Maybe it would be enough to comment out the eval method, and the symbol in __init__.py

Things are going to move around. I don't think it is difficult to write this from scratch after the modules have been split up, with the TODOs added for missing functions. A problem with commented out code is that it too is needs to be maintained as things change or, more likely, it is skipped and then it is more wrong when one goes to uncomment it.

So personally, I would prefer that when it goes back in the person not try "cut and paste" but rather "think and add". If one finds it convenient to cut and paste, do that on the current code, not the old code.

Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. After merge this, let's divide the code in sections, and then let's proceed with the improvement of the entries.

@rocky rocky merged commit 3433c53 into master Feb 20, 2023
@rocky rocky deleted the remove-WordFrequencyData branch February 20, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants