Fixes DialogHost visibility on VM disconnect (#3069) #3092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Keboo added the release notes 
| Just asking to see whether it might be considered to get this included in a v4.7.2 patch if you think v4.8 might be a while. |
Reverted change to make sure that we remove dead weak references.
Keboo approved these changes Feb 20, 2023
| Hi @tblong thank you very much for this. I threw in a UI test to cover this to ensure we don't break this behavior in the future. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #3069
On reconnect to a VM where a
DialogHost's popup was previously visible, theDialogHost.IsOpenproperty would remaintruein theDialogHost.Loadedevent handler however the popup'sIsOpenproperty would befalse. This fix ensures the two properties match and the position of the popup remains consistent on reconnect to the VM where the application is running.