DHFPROD-10507: in-memory fuzzy match #8006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
prolonMarkLogic suggested changes Aug 22, 2023
ryanjdew force-pushed the DHFPROD-10507 branch from 6712ebf to 69323ab Compare prolonMarkLogic previously approved these changes Aug 22, 2023
There was a problem hiding this comment.
@ryanjdew I was testing different scenarios, and all of them works perfect! excellent work.
rahulvudutala previously approved these changes Aug 23, 2023
ryanjdew dismissed stale reviews from rahulvudutala and prolonMarkLogic via 23a9422 ryanjdew force-pushed the DHFPROD-10507 branch from 69323ab to 23a9422 Compare 
| @ryanjdew I still see the ignore list issue, where even when I add the values in the list, they are getting matched in preview Screen.Recording.2023-08-23.at.4.48.06.PM.mov |
ryanjdew force-pushed the DHFPROD-10507 branch from 23a9422 to 126d5ad Compare 
ngodugu-marklogic previously approved these changes Aug 24, 2023
prolonMarkLogic previously approved these changes Aug 24, 2023
ryanjdew dismissed stale reviews from prolonMarkLogic and ngodugu-marklogic via f601241 ryanjdew force-pushed the DHFPROD-10507 branch from 126d5ad to f601241 Compare ngodugu-marklogic approved these changes Aug 24, 2023
rahulvudutala approved these changes Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Checklist:
- Note: do not change the belowOwner:
JIRA_ID included in all the commit messages
PR title is in the format JIRA_ID:Title
Rebase the branch with upstream
Squashed all commits into a single commit
Added Tests
N/A Ran newly added/edited cypress tests on Firefox locally
N/A Remove any PII info and customer data
Reviewer:
Reviewed Tests
N/A Added to Release Wiki
N/A Review any PII info and customer data