Make extract_stack resilient to lacking frames. #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
elprans approved these changes Oct 7, 2023
fantix added a commit that referenced this pull request Oct 12, 2023
Merged
fantix added a commit that referenced this pull request Oct 13, 2023
Changes ======= * Port uvloop to Python 3.12 (#570) (by @1st1, @fantix in 9f82bd7 for #569) * Upgrade libuv to v1.46.0 (#571) (by @fantix in 2e1978c for #571) Fixes ===== * CI fixes (#520, #553) (by @altendky in 7783f1c, @dulmandakh in 1dd40f1) * Make extract_stack resilient to lacking frames. (#563) (by @jhance in 0687643 for #563)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We are using uvloop in conjunction with an implementation of GRPC (not the default one) that is using C++ and Cython instead of native code. This means we try to do things with the loop while not holding a frame, which causes crashes when we enable debug mode on the loop. From reading Cython documentation this seems kinda impossible to adjust to have a frame. But it is fairly easy to just not fail hard here.