Shield Pool.release() from task cancellation. #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1st1 reviewed Mar 29, 2017
asyncpg/pool.py Outdated
| # Use asyncio.shield() to guarantee that task cancellation | ||
| # does not prevent the connection from being returned to the | ||
| # pool properly. | ||
| return await asyncio.shield(self._release_impl(connection)) |
Member
There was a problem hiding this comment.
Please pass the loop arg explicitly.
elprans force-pushed the pool-release-cancellation branch from ab6fd40 to b7ab545 Compare 
Use asyncio.shield() to guarantee that task cancellation does not prevent the connection from being returned to the pool properly. Fixes: #97.
elprans force-pushed the pool-release-cancellation branch from b7ab545 to 29620c1 Compare 1st1 approved these changes Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Use asyncio.shield() to guarantee that task cancellation
does not prevent the connection from being returned to the
pool properly.
Fixes: #97.