Fix integer boundaries #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Since '0' is in the positive half, negative range is slightly wider: abs(min_value) == (max_value + 1)
Since there is no error in a value representation and PyLong_AsLong(-Long) raises exactly that exception if the value exceed the destination range, it should be OverflowError instead of ValueError. Also make error message be similar to one from the original OverflowError raised by PyLong_AsLong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
During development I got strange results when some integer values are passed as query parameters.
I expected
0xfffffffeasint4should raise an exception, but it saved as "-2". Moreover,0xffffffffe(there is one "f" more) gave the same result.It was understandable that it is a result of a wrong typecasting.
Debugging led to this PR. Almost all comments are in commit messages.
Firstly I tried to use
PyLong_AsLongAndOverflowandPyLong_AsLongLongAndOverflowbut could not reraise exceptions if they are not connected with overflowing. That is why "try..except" is used here.To make the code be compatible between systems I use
sizeof(val) > Xto make a compiler optimize the rest of a condition.Also I think it is wise to have the same exception among all ranges (previously either
ValueErrororOverflowErrorraised depending on how big passed value is).