Fix: Indent code to ensure 'j' is within for-loop in GQRS algorithm #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| @Biboulder Thanks for picking this up! Please could you rebase the pull request on the main branch, and if possible add a simple test that covers the |
Member
| I rebased on main and opened a new PR: #499 |
tompollard added a commit that referenced this pull request Jul 10, 2024
…499) As discussed in #489: > "The variable j was not properly scoped within the for-loop in the sm method, leading to an UnboundLocalError when j was accessed outside the loop." #489 needs rebasing on the main branch to allow tests to run. This pull request is just a cherry-pick of the commit in #489, on top of the current version of main (I can't push to the other branch directly, because its on a forked repo).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The variable j was not properly scoped within the for-loop in the sm method, leading to an UnboundLocalError when j was accessed outside the loop.