Fix code style #440
Merged
Fix code style #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits January 25, 2023 13:02
If all code is supposed to be formatted according to black, we want to check this and fail if any code is not formatted correctly. Simply running "black ." here doesn't help, as that simply rewrites any incorrectly-formatted files and exits with status 0. Instead, run with --check (fail if files are wrongly formatted) and --diff (print differences to standard output).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We decided a while ago to require code in this project to be formatted using
black.Fix the style of
edf.pyaccordingly. Require correct formatting for future pull requests.