Skip to content

Added ORDER BY to delete operation. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2022
Merged

Added ORDER BY to delete operation. #6

merged 1 commit into from
Apr 10, 2022

Conversation

nagmat84
Copy link
Collaborator

@nagmat84 nagmat84 commented Apr 7, 2022 •
edited
Loading

Partially fixes LycheeOrg/Lychee#1251

As MySQL does not comly to ANSI SQL and does not support statement consistency, but only simple row consistency, the order of rows is important when a complete sub-tree is deleted.
@nagmat84 nagmat84 mentioned this pull request Apr 7, 2022
Closed
@nagmat84 nagmat84 requested review from ildyria and kamil4 April 7, 2022 19:42
@nagmat84
Copy link
Collaborator Author

nagmat84 commented Apr 7, 2022

Maybe someone of you (@kamil4, @ildyria) understands why 1 out of 9 tests is failing. If I understand the output of the failing test correctly, it is not the code itself which fails, but the PHP lexer when PHPunit tries to calculate the test coverage.
@ildyria ildyria mentioned this pull request Apr 10, 2022
Merged
@ildyria
Copy link
Member

ildyria commented Apr 10, 2022

LGTM, see: #7
@nagmat84 nagmat84 merged commit 973684d into v5 Apr 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix_order_of_deletion branch April 10, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@nagmat84 @ildyria