Change btree.c to work with all versions of LMDB #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closed
| pretty sure it does not have a performance impact on earlier versions Because it does a version check D …On Sun, 22 Dec 2019, 17:00 Keith Maxwell, ***@***.***> wrote: Separated out of #13 <https://github.com/LumoSQL/LumoSQL/pull/13> Potentially has a negative effect on performance, *do not merge until the performance impact has been assessed* ------------------------------ You can view, comment on, or merge this pull request online at: https://github.com/LumoSQL/LumoSQL/pull/16 Commit Summary - WIP - Add LumoSQL copyright message. File Changes - *M* README.md <https://github.com/LumoSQL/LumoSQL/pull/16/files#diff-0> (19) - *M* lmdb-backend/src/btree.c <https://github.com/LumoSQL/LumoSQL/pull/16/files#diff-1> (43) Patch Links: - https://github.com/LumoSQL/LumoSQL/pull/16.patch - https://github.com/LumoSQL/LumoSQL/pull/16.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/LumoSQL/LumoSQL/pull/16?email_source=notifications&email_token=AA6DBALIUVXGW2NXVKOGOY3QZ6MI5A5CNFSM4J6MT6PKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ICGI5FA>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6DBANQ6FZZXSTP3QNNK2DQZ6MI5ANCNFSM4J6MT6PA> . |
| Closed in error, reopening this PR is blocked for me, reopened as https://github.com/LumoSQL/LumoSQL/pull/18 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Separated out of https://github.com/LumoSQL/LumoSQL/pull/13
Potentially has a negative effect on performance, do not merge until the performance impact has been assessed by sharing bench marking data