Skip to content

Add missing comparison operators #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add missing comparison operators #3136

wants to merge 3 commits into from

Conversation

JasonHise
Copy link

I noticed that eq was not being recognized by the language server. Adding the missing eq, lt, and le entries to vm.BINARY_OP and binaryMap resolves this issue.
@tomlau10
Copy link
Contributor

This has been discussed before, and author decided not to support them: #1882 (comment)

IIUC, the major reason is that they will be adjusted to boolean type no matter what 🤔
#2750 (reply in thread)
@JasonHise
Copy link
Author

Understood, thanks!
@JasonHise JasonHise closed this Mar 27, 2025
@NohaZaman
Copy link

I noticed that eq was not being recognized by the language server. Adding the missing eq, lt, and le entries to vm.BINARY_OP and binaryMap resolves this issue.

This has been discussed before, and author decided not to support them: #1882 (comment)

IIUC, the major reason is that they will be adjusted to boolean type no matter what 🤔 #2750 (reply in thread)
@NohaZaman
Copy link

I noticed that eq was not being recognized by the language server. Adding the missing eq, lt, and le entries to vm.BINARY_OP and binaryMap resolves this issue.
1 similar comment
@NohaZaman
Copy link

I noticed that eq was not being recognized by the language server. Adding the missing eq, lt, and le entries to vm.BINARY_OP and binaryMap resolves this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@JasonHise @tomlau10 @NohaZaman