Skip to content

搜索引用时添加"检查 generic 穿透的情况" #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

搜索引用时添加"检查 generic 穿透的情况" #281

wants to merge 1 commit into from

Conversation

@uhziel
Copy link
Contributor

@uhziel uhziel commented Dec 4, 2020

目前只是实现基本的检查 generic，有个 TODO 测试用例还没有实现，需先弄明白下面这个疑问。

@sumneko 请教下 local a, b = func() 的ast里，怎么找到 b 了。一路顺着 func() 往上找，只找到 a。
@uhziel uhziel mentioned this pull request Dec 4, 2020
Closed
@sumneko
Copy link
Collaborator

sumneko commented Dec 4, 2020

call 有个 extParent 字段，里面存放着从第2个开始的 select。
这个设计最初是为了节省一张表（绝大部分call的返回值都是0个或1个），不过可能会给guide带来一些麻烦。
以后可能考虑改掉。
@sumneko
Copy link
Collaborator

sumneko commented Dec 4, 2020

guide.searchRefsAsFunctionReturn 有检查 extParent 字段
@uhziel
Copy link
Contributor Author

uhziel commented Dec 4, 2020

感谢这么迅速的回馈，我看下~
@sumneko
Copy link
Collaborator

sumneko commented Dec 5, 2020

非常感谢你提出的PR，由于该问题已于 efd78df 解决，因此不再接受此PR。
@sumneko sumneko closed this Dec 5, 2020
@uhziel
Copy link
Contributor Author

uhziel commented Dec 7, 2020

学习下你的实现~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@uhziel @sumneko