Skip to content

Conversation

@lewis6991
Copy link
Contributor

@lewis6991 lewis6991 commented Sep 25, 2023

Currently LuaLS will expand:

---<??> local x = function (x, y) end

with:

---comment ---@param x any ---@param y any local x = function (x, y) end

This change adds a variation of this snippet to expand:

--- <??> local x = function (x, y) end

with:

--- comment --- @param x any --- @param y any local x = function (x, y) end
Currently LuaLS will expand: ```lua ---<??> local x = function (x, y) end ``` with: ```lua ---comment ---@param x any ---@param y any local x = function (x, y) end ``` This change adds a variation of this snippet to expand: ```lua --- <??> local x = function (x, y) end ``` with: ```lua --- comment --- @param x any --- @param y any local x = function (x, y) end ```
@llllvvuu
Copy link

Thoughts on just making a breaking change here instead of adding a variation?

@sumneko sumneko merged commit f4548b5 into LuaLS:master Sep 26, 2023
@sumneko
Copy link
Collaborator

sumneko commented Sep 26, 2023

Thank you!

@lewis6991 lewis6991 deleted the feat/snipspace branch September 26, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants