🔧 fix(model): enhance Windows model loading with robust path handling #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
sudoskys commented Mar 4, 2025
sudoskys commented - Improve model loading strategies for Windows compatibility
- Add multiple fallback mechanisms for loading models with special characters
- Enhance error logging and temporary file management
- Optimize path resolution and loading attempts
- Improve model loading strategies for Windows compatibility - Add multiple fallback mechanisms for loading models with special characters - Enhance error logging and temporary file management - Optimize path resolution and loading attempts
Closed
…handling - Streamline model loading process with fewer strategies - Enhance temporary file management using `mkstemp()` - Improve error logging and file cleanup - Remove redundant path validation checks - Optimize Windows temporary file deletion logic
…h test - Modify test case to explicitly set `allow_fallback=False` - Improve test configuration for language detection with custom model path - Enhance test coverage for model loading with Chinese characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.