Skip to content

Conversation

Piloalucard
Copy link
Member

Summary of changes

This pull request includes following changes or fixes.

  • Compatible code with Microsoft Visual C++ Compiler
  • Support of Windows Server 2022
  • Support of Windows Server 2025
  • Support of Windows 11

Description

Code was updated to be compatible again with Windows platform. Microsoft mandates compilation with Microsoft tools to give support, with that said the code needed to be compatible with Microsoft Visual C++ Compiler for a new version to be built.
Macros we're added to comply with this and change the behavior depending on which platform the project is being built.

Type of change

  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have confirmed my fix is effective or that my feature works
@piste-jp
Copy link
Member

piste-jp commented May 8, 2025

Sorry, I cannot understand what is changed form #510.

I would like to ask you below.

  1. Merge all your changes into one commit with git rebase -i ...
  2. Start over from simplified ltfs_arch_ops.h

I would like to provide a base branch which provides more comfortable ltfs_arch_ops.h for this project to you. It might not be compilable because win_util.h is only on your side.

Please let me have a few days.

Copy link
Contributor

@juliocelon juliocelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for all your hard work, Gustavo!

Copy link
Contributor

@amissael95 amissael95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, the merge can be done to the branch "v2.4.8-windows" since it would not affect any stable branch.

Copy link
Member

@piste-jp piste-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good because this merge might be done to [2.4.8-windows-support](https://github.com/LinearTapeFileSystem/ltfs/tree/v2.4.8-windows-support) branch.

Copy link

@syaoraang syaoraang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time is in our shoulder,s but more review will be performed later.
Approved but need to be improved later with everyones review.

@juliocelon juliocelon merged commit dce31f8 into LinearTapeFileSystem:v2.4.8-windows-support May 16, 2025
9 checks passed
@piste-jp piste-jp mentioned this pull request Aug 24, 2025
6 tasks
@Piloalucard Piloalucard deleted the windows branch October 7, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

7 participants