Skip to content

CI: make timeout configurable for install jobs in check-package.yml #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

CI: make timeout configurable for install jobs in check-package.yml #412

merged 1 commit into from
Jun 23, 2025

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Jun 23, 2025 •
edited by github-actions bot
Loading

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did all existing and newly added tests pass locally?

What does this PR do?

address some long installation

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

📚 Documentation preview 📚: https://lit-utilities--412.org.readthedocs.build/en/412/
@github-actions github-actions bot added the ci/cd Continuous integration and delivery label Jun 23, 2025
@Borda Borda requested a review from Copilot June 23, 2025 19:50
Copilot AI reviewed Jun 23, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Introduces a configurable timeout for the install jobs in the check-package.yml workflow.

  • Adds a new timeout-minutes input with a default of 30 minutes.
  • Updates both archive and wheel install steps to use the new input instead of a fixed 10-minute timeout.
Comments suppressed due to low confidence (1)

.github/workflows/check-package.yml:60

  • The indentation for the new timeout-minutes input block does not align with the existing inputs entries, which will cause a YAML parsing error. Please adjust the indent level to match the surrounding SAMPLE_ENV_VARIABLE entry.
 timeout-minutes:
@Borda Borda merged commit 9fd58c1 into main Jun 23, 2025
60 checks passed
@Borda Borda deleted the ci/pkg-check-timeout branch June 23, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd Continuous integration and delivery

1 participant

@Borda