Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Conversation

@edgarriba
Copy link
Contributor

@edgarriba edgarriba commented Jun 16, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Jun 16, 2021

Hello @edgarriba! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-17 10:00:55 UTC
@mergify mergify bot requested a review from Borda June 16, 2021 16:53
@edgarriba
Copy link
Contributor Author

@tchaton initial proposal for a template tutorial file. Please, indicate what you miss or what else we could include.

@edgarriba
Copy link
Contributor Author

@Borda can we disable [E402] module level import not at top of file ?

I guess there are some educational cases where we might want to include some imports in the top of a cell instead of the top of the file.

@Borda Borda added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 16, 2021
@Borda
Copy link
Contributor

Borda commented Jun 16, 2021

@edgarriba eventually you can flag it with noqa but fine to add this ignore :]

@Borda Borda marked this pull request as ready for review June 16, 2021 21:32
@justusschock
Copy link
Member

How do we make sure, the template isn't deployed?

@edgarriba
Copy link
Contributor Author

@justusschock good point - @Borda can we enable/disable that ?

@Borda
Copy link
Contributor

Borda commented Jun 17, 2021

How do we make sure, the template isn't deployed?

you need to list each notebook you want to add in docs, so no problem :P
Lightning-AI/pytorch-lightning#8004 (comment)

@Borda Borda requested a review from ethanwharris June 17, 2021 08:59
@Borda Borda enabled auto-merge (squash) June 17, 2021 08:59
@Borda Borda disabled auto-merge June 17, 2021 09:41
@Borda Borda enabled auto-merge (squash) June 17, 2021 09:42
@Borda Borda disabled auto-merge June 17, 2021 09:54
@Borda Borda enabled auto-merge (squash) June 17, 2021 09:56
@Borda Borda merged commit 839ada4 into main Jun 17, 2021
@Borda Borda deleted the template branch June 17, 2021 10:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation enhancement New feature or request

5 participants