Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Apr 1, 2025

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes broken link and so blocked CI

This pull request includes a small but important update to a URL in the MHAttention.py file. The change updates a link to a more accurate source for visualizing self-attention mechanisms.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda requested a review from ethanwharris as a code owner April 1, 2025 12:14
@Borda Borda requested a review from Copilot April 1, 2025 12:14
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a broken link in the documentation section of the MHAttention module by updating the URL for the Self-Attention visualization.

  • Updated the Self-Attention link in the documentation comments.
  • Ensured the new link directs to the correct page for visualization.
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69%. Comparing base (773cb27) to head (83a525b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@ ## main #384 +/- ## =================================== Coverage 69% 69% =================================== Files 2 2 Lines 441 441 =================================== Hits 306 306 Misses 135 135 
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@Borda Borda merged commit 0518bee into main Apr 1, 2025
14 of 17 checks passed
@Borda Borda deleted the doc/link branch April 1, 2025 12:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

1 participant