Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Conversation

@speediedan
Copy link
Contributor

Validated (locally) the Fine-Tuning Scheduler (FTS) tutorial for FTS/Lightning/PyTorch 2.4.0 (as of the recent 2.4.0 Lightning commit).
(this PR is currently using 2.3.3 until Lightning and FTS 2.4.x are released)

The only minor changes in this PR are to explicitly set datasets trust_remote_code (which will be mandatory with Datasets 3.x) and to remove a reference to the now unsupported PT 2.0.x

Thank you for all your work and your consistently valuable contributions to the open-source ML community!

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Updates the Fine-Tuning Scheduler tutorial to prepare for 2.4.0 tutorial publishing.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

…yTorch/Lightning 2.4.0 and remove reference to unsupported PT 2.0.x
@mergify mergify bot requested a review from Borda July 26, 2024 19:59
@codecov
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70%. Comparing base (a01f01f) to head (9e1f233).

Additional details and impacted files
@@ Coverage Diff @@ ## main #351 +/- ## =================================== Coverage 70% 70% =================================== Files 2 2 Lines 441 441 =================================== Hits 307 307 Misses 134 134 
@speediedan speediedan marked this pull request as ready for review July 26, 2024 20:23
@speediedan speediedan requested a review from ethanwharris as a code owner July 26, 2024 20:23
@Borda Borda self-requested a review July 26, 2024 20:25
Borda
Borda previously approved these changes Jul 26, 2024
@Borda Borda added the enhancement New feature or request label Jul 26, 2024
@Borda Borda self-requested a review July 26, 2024 21:10
@Borda Borda dismissed their stale review July 26, 2024 21:10

some last changes need to be validated

…torial, FTS will install lightning by default unless overridden with an env variable to install the standalone pytorch-lightning
@Borda Borda merged commit 36f10f1 into Lightning-AI:main Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

2 participants