Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Conversation

@Borda
Copy link
Contributor

@Borda Borda commented Jul 19, 2024

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

fixing internal tests and some other notebooks

Getting requirements to build wheel did not run successfully. │ exit code: 1 ╰─> [48 lines of output] running egg_info writing lib3/PyYAML.egg-info/PKG-INFO writing dependency_links to lib3/PyYAML.egg-info/dependency_links.txt writing top-level names to lib3/PyYAML.egg-info/top_level.txt Traceback (most recent call last): File "/opt/hostedtoolcache/Python/3.10.14/x64/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module> main() File "/opt/hostedtoolcache/Python/3.10.14/x64/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main json_out['return_val'] = hook(**hook_input['kwargs']) File "/opt/hostedtoolcache/Python/3.10.14/x64/lib/python3.10/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 1[18](https://github.com/Lightning-AI/tutorials/actions/runs/10014342822/job/27683863858?pr=325#step:6:19), in get_requires_for_build_wheel return hook(config_settings) File "/tmp/pip-build-env-d6d0ojk0/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 327, in get_requires_for_build_wheel return self._get_build_requires(config_settings, requirements=[]) File "/tmp/pip-build-env-d6d0ojk0/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 297, in _get_build_requires self.run_setup() File "/tmp/pip-build-env-d6d0ojk0/overlay/lib/python3.10/site-packages/setuptools/build_meta.py", line 313, in run_setup exec(code, locals()) File "<string>", line 271, in <module> File "/tmp/pip-build-env-d6d0ojk0/overlay/lib/python3.10/site-packages/setuptools/__init__.py", line 108, in setup return distutils.core.setup(**attrs) File "/tmp/pip-build-env-d6d0ojk0/overlay/lib/python3.10/site-packages/setuptools/_distutils/core.py", line 184, in setup return run_commands(dist) File "/tmp/pip-build-env-d6d0ojk0/overlay/lib/python3.10/site-packages/setuptools/_distutils/core.py", line [20](https://github.com/Lightning-AI/tutorials/actions/runs/10014342822/job/27683863858?pr=325#step:6:21)0, in run_commands dist.run_commands() File "/tmp/pip-build-env-d6d0ojk0/overlay/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 970, in run_commands self.run_command(cmd) File "/tmp/pip-build-env-d6d0ojk0/overlay/lib/python3.10/site-packages/setuptools/dist.py", line 974, in run_command super().run_command(command) File "/tmp/pip-build-env-d6d0ojk0/overlay/lib/python3.10/site-packages/setuptools/_distutils/dist.py", line 989, in run_command cmd_obj.run() File "/tmp/pip-build-env-d6d0ojk0/overlay/lib/python3.10/site-packages/setuptools/command/egg_info.py", line 3[21](https://github.com/Lightning-AI/tutorials/actions/runs/10014342822/job/27683863858?pr=325#step:6:22), in run self.find_sources() File "/tmp/pip-build-env-d6d0ojk0/overlay/lib/python3.10/site-packages/setuptools/command/egg_info.py", line 329, in find_sources mm.run() File "/tmp/pip-build-env-d6d0ojk0/overlay/lib/python3.10/site-packages/setuptools/command/egg_info.py", line 550, in run self.add_defaults() File "/tmp/pip-build-env-d6d0ojk0/overlay/lib/python3.10/site-packages/setuptools/command/egg_info.py", line 588, in add_defaults sdist.add_defaults(self) File "/tmp/pip-build-env-d6d0ojk0/overlay/lib/python3.10/site-packages/setuptools/command/sdist.py", line 102, in add_defaults super().add_defaults() File "/tmp/pip-build-env-d6d0ojk0/overlay/lib/python3.10/site-packages/setuptools/_distutils/command/sdist.py", line [25](https://github.com/Lightning-AI/tutorials/actions/runs/10014342822/job/27683863858?pr=325#step:6:26)0, in add_defaults self._add_defaults_ext() File "/tmp/pip-build-env-d6d0ojk0/overlay/lib/python3.10/site-packages/setuptools/_distutils/command/sdist.py", line 335, in _add_defaults_ext self.filelist.extend(build_ext.get_source_files()) File "<string>", line 201, in get_source_files File "/tmp/pip-build-env-d6d0ojk0/overlay/lib/python3.10/site-packages/setuptools/_distutils/cmd.py", line 107, in __getattr__ raise AttributeError(attr) AttributeError: cython_sources [end of output] note: This error originates from a subprocess, and is likely not a problem with pip. error: subprocess-exited-with-error × Getting requirements to build wheel did not run successfully. │ exit code: 1 ╰─> See above for output. 

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda requested a review from ethanwharris as a code owner July 19, 2024 21:13
@Borda Borda added the bug / fix Something isn't working label Jul 19, 2024
@codecov
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71%. Comparing base (ac8f7ba) to head (61befd8).

Additional details and impacted files
@@ Coverage Diff @@ ## main #326 +/- ## =================================== Coverage 71% 71% =================================== Files 2 2 Lines 401 401 =================================== Hits 285 285 Misses 116 116 
@Borda Borda merged commit fe4e7b7 into main Jul 19, 2024
@Borda Borda deleted the ci/pyyaml branch July 19, 2024 21:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug / fix Something isn't working topic: CI/CD

1 participant