Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Conversation

@Borda
Copy link
Contributor

@Borda Borda commented Jan 25, 2023

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

unify all python related configs in pyproject.toml
replace flake8 by ruff

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #224 (5465056) into main (7e3565d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@ Coverage Diff @@ ## main #224 +/- ## =================================== Coverage 73% 73% =================================== Files 2 2 Lines 382 382 =================================== Hits 280 280 Misses 102 102 
@Borda
Copy link
Contributor Author

Borda commented Jan 25, 2023

let's wait the PL update is resolved in #222

@Borda Borda requested a review from akihironitta January 25, 2023 17:11
@Borda Borda added the ci/cd label Jan 25, 2023
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
@mergify mergify bot added the has conflicts label Mar 1, 2023
@Borda Borda enabled auto-merge (squash) March 24, 2023 14:28
@mergify mergify bot removed the has conflicts label Mar 24, 2023
@Borda Borda disabled auto-merge March 24, 2023 15:28
@Borda Borda merged commit 4327b88 into main Mar 24, 2023
@Borda Borda deleted the pyproject branch March 24, 2023 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

2 participants