Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Conversation

@phlippe
Copy link
Contributor

@phlippe phlippe commented Jun 7, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
    -> This PR was discussed with @tchaton in the PL Slack channel.
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

This PR adds a new tutorial on Graph Neural Networks with PyTorch Lightning. This tutorial discusses fundamentals on GNNs, such as Graph Convolutions and Graph Attention layers. It also includes a section on experiments for semi-supervised node classification and molecule generalization. The tutorial is an adapted version of the original GNN tutorial for the Deep Learning course at the University of Amsterdam (link).

The png and svg files are images that are included in the notebook.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from Borda June 7, 2021 13:45
@phlippe phlippe marked this pull request as ready for review June 7, 2021 14:47
@@ -0,0 +1,3 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this need to be check if the image is inserted in the notebook or we need to copy separately...

@Borda Borda added enhancement New feature or request Example Example / Demo / Tutorial labels Jun 7, 2021
@Borda
Copy link
Contributor

Borda commented Jun 8, 2021

  • This PR was discussed with @tchaton in the PL Slack channel

pls loop me in next time 🐰

@Lightning-AI Lightning-AI deleted a comment from pep8speaks Jun 9, 2021
@Lightning-AI Lightning-AI deleted a comment from pep8speaks Jun 9, 2021
Copy link
Contributor

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems the notebooks are not executed, need to check the details...

NOTE, it is not your issue but rather ours, but I would like to use your PR to debug this issue :]

@Borda
Copy link
Contributor

Borda commented Jun 14, 2021

ok, the wheels do not help much as they are missing patch PT versions, see pyg-team/pytorch_geometric#2735

@Borda
Copy link
Contributor

Borda commented Jun 14, 2021

@phlippe seems all remaining issues were resolved, shall we run more training epochs as now the tests take a few minutes only

@Borda Borda self-requested a review June 14, 2021 20:35
Comment on lines 17 to 23
# In this tutorial, we will discuss the application of neural networks on graphs.
# Graph Neural Networks (GNNs) have recently gained increasing popularity in both applications and research, including domains such as social networks, knowledge graphs, recommender systems, and bioinformatics.
# While the theory and math behind GNNs might first seem complicated, the implementation of those models is quite simple and helps in understanding the methodology.
# Therefore, we will discuss the implementation of basic network layers of a GNN, namely graph convolutions, and attention layers.
# Finally, we will apply a GNN on a node-level, edge-level, and graph-level tasks.
#
# Below, we will start by importing our standard libraries.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is rather description, note that description is added to the notebook

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. The paragraph is now removed from the notebook and merged into the description in the .meta.yaml file.

@phlippe
Copy link
Contributor Author

phlippe commented Jun 14, 2021

@phlippe seems all remaining issues were resolved, shall we run more training epochs as now the tests take a few minutes only

Great to hear! The notebook loads pre-trained models so that it only runs evaluations. However, if we comment out the download of the pre-trained models, we can check whether a training also works.

Copy link
Contributor

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!, Thx 🚀

@Borda Borda enabled auto-merge (squash) June 15, 2021 12:20
@Borda Borda merged commit 1c8d22e into Lightning-AI:main Jun 15, 2021
@phlippe phlippe deleted the gnn-tutorial branch July 28, 2021 07:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request Example Example / Demo / Tutorial

4 participants