Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

replace TensorBoard by CSV logger in PL examples #166

Merged
merged 6 commits into from
Apr 28, 2022
Merged

replace TensorBoard by CSV logger in PL examples #166

merged 6 commits into from
Apr 28, 2022

Conversation

@Borda
Copy link
Contributor

@Borda Borda commented Apr 23, 2022 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

This allows us to inline training charts 🐰
Part of #19

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃
@Borda Borda added the enhancement New feature or request label Apr 23, 2022
@codecov
Copy link

codecov bot commented Apr 23, 2022 •
edited
Loading

Codecov Report

Merging #166 (ab93b01) into main (4414aaf) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@ ## main #166 +/- ## =================================== Coverage 75% 75% =================================== Files 2 2 Lines 370 370 =================================== Hits 276 276 Misses 94 94
@Borda Borda changed the title replace TensorBoard by CSV logger replace TensorBoard by CSV logger in PL examples Apr 23, 2022
@kaushikb11
Copy link
Contributor

kaushikb11 commented Apr 25, 2022

@Borda Why are we doing this change?
@Borda
Copy link
Contributor Author

Borda commented Apr 25, 2022 •
edited
Loading

Why are we doing this change?

because of this, you can see the plot directly in the notebook
Otherwise, there is a way to verify that it really trains/learns anything...
rohitgr7
rohitgr7 approved these changes Apr 26, 2022
View reviewed changes
@Borda Borda merged commit 4c1f4d4 into main Apr 28, 2022
@Borda Borda deleted the refactor/csv-logger branch April 28, 2022 07:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

3 participants

@Borda @kaushikb11 @rohitgr7