Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Conversation

@Borda
Copy link
Contributor

@Borda Borda commented Dec 1, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice tool! perfect as a ci job

Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@Borda Borda enabled auto-merge (squash) December 1, 2021 22:27
@Borda
Copy link
Contributor Author

Borda commented Dec 3, 2021

I am fixing some dead links in the lectures and seems that one or more notebooks can't run again...
@phlippe mind have a look at what is happening there? 🐰

@phlippe
Copy link
Contributor

phlippe commented Dec 3, 2021

Ah, the new PyTorch Geometric version broke our checkpoints by renaming some internal layers. I corrected the checkpoint, but we need to update the PyTorch Geometric. I will look into that tomorrow.

@Borda
Copy link
Contributor Author

Borda commented Dec 3, 2021

I will look into that tomorrow.

do you prefer to update the notebook/checkpoint or just freeze the package version?

@phlippe
Copy link
Contributor

phlippe commented Dec 4, 2021

do you prefer to update the notebook/checkpoint or just freeze the package version?

I think in this case it made more sense to update the version in the meta file since we went from PyG 1.7 to 2.0. I do not expect more breaking changes any time soon.

@mergify mergify bot added the has conflicts label Dec 4, 2021
@mergify mergify bot removed the has conflicts label Dec 4, 2021
@Borda Borda merged commit 214d1d1 into main Dec 4, 2021
@Borda Borda deleted the ci/docs-link branch December 4, 2021 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ci/cd enhancement New feature or request

4 participants