Skip to content

Conversation

@SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Feb 18, 2021

What does this PR do?

I noticed when running a #6047 using a custom DDPPlugin, that we do not make parallel devices optional, which can be injected at runtime via the accelerator connector. This means we can't enable find_unused_parameters=False or load certain plugins to pass into the trainer.

This PR makes parallel devices optional across all training type plugins.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@SeanNaren SeanNaren added the bug Something isn't working label Feb 18, 2021
@SeanNaren SeanNaren added this to the 1.2 milestone Feb 18, 2021
@SeanNaren SeanNaren self-assigned this Feb 18, 2021
@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #6051 (63a8952) into master (77f6aa4) will decrease coverage by 0%.
The diff coverage is 100%.

@@ Coverage Diff @@ ## master #6051 +/- ## ====================================== - Coverage 93% 93% -0%  ====================================== Files 160 160 Lines 11400 11406 +6 ====================================== + Hits 10622 10627 +5  - Misses 778 779 +1 
@SeanNaren SeanNaren marked this pull request as draft February 18, 2021 10:43
@SeanNaren SeanNaren changed the title Make parallel devices optional across all plugins [WIP] Make parallel devices optional across all plugins Feb 18, 2021
@SeanNaren
Copy link
Contributor Author

I'll add tests to make sure this works

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch !

@SeanNaren SeanNaren changed the title [WIP] Make parallel devices optional across all plugins Make parallel devices optional across all plugins Feb 18, 2021
@SeanNaren SeanNaren marked this pull request as ready for review February 18, 2021 12:05
@SeanNaren SeanNaren enabled auto-merge (squash) February 18, 2021 12:05
@SeanNaren SeanNaren merged commit ffdcb62 into master Feb 18, 2021
@SeanNaren SeanNaren deleted the fix/optional branch February 18, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

4 participants