Skip to content

Conversation

@ctlaltdefeat
Copy link

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fix callback metrics for non-Tensor types.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ctlaltdefeat ctlaltdefeat changed the title Update logging.py Fix callback metrics for non-Tensor types Dec 7, 2019
@williamFalcon williamFalcon merged commit 58cc6e1 into Lightning-AI:master Dec 7, 2019
@Borda
Copy link
Collaborator

Borda commented Dec 7, 2019

just for the record, it is "rebase" of #550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants