Skip to content

Conversation

@katzkowski
Copy link

@katzkowski katzkowski commented Jun 4, 2023

What does this PR do?

Fixes (doesn't close) #16830 for PredictionLoop

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jun 4, 2023
@katzkowski katzkowski marked this pull request as ready for review June 4, 2023 17:50
@stale stale bot added the won't fix This will not be worked on label Jun 19, 2023
@Lightning-AI Lightning-AI deleted a comment from stale bot Jun 19, 2023
@stale stale bot removed the won't fix This will not be worked on label Jun 19, 2023
@awaelchli awaelchli added data handling Generic data-related topic trainer: predict feature Is an improvement or enhancement community This PR is from the community labels Jun 20, 2023
@stale stale bot added the won't fix This will not be worked on label Aug 12, 2023
@awaelchli awaelchli added this to the 2.1 milestone Aug 12, 2023
@awaelchli awaelchli removed the won't fix This will not be worked on label Aug 12, 2023
@Lightning-AI Lightning-AI deleted a comment from stale bot Aug 12, 2023
@mergify mergify bot added the has conflicts label Sep 5, 2023
@carmocca carmocca modified the milestones: 2.1, 2.2 Oct 5, 2023
@Borda
Copy link
Collaborator

Borda commented Nov 18, 2023

@katzkowski could you pls check the merge conflists? 🐰

@github-actions github-actions bot added the docs Documentation related label Nov 20, 2023
@mergify mergify bot removed the has conflicts label Nov 20, 2023
@katzkowski katzkowski changed the title Support all CombinedLoader modes in prediction loop [WIP] Support all CombinedLoader modes in prediction loop Nov 20, 2023
@gitguardian
Copy link

gitguardian bot commented Jan 16, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 78fa3af tests/tests_app/utilities/test_login.py View secret
- Base64 Basic Authentication 78fa3af tests/tests_app/utilities/test_login.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@mergify mergify bot added the has conflicts label Feb 1, 2024
@awaelchli awaelchli modified the milestones: 2.2, 2.3 Feb 3, 2024
@mergify mergify bot removed the has conflicts label Feb 23, 2024
@awaelchli awaelchli modified the milestones: 2.3, future Jun 2, 2024
@bhimrazy bhimrazy marked this pull request as draft August 28, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community This PR is from the community data handling Generic data-related topic docs Documentation related feature Is an improvement or enhancement has conflicts pl Generic label for PyTorch Lightning package trainer: predict

4 participants