Skip to content

Conversation

@InfiniteXyy
Copy link
Contributor

@InfiniteXyy InfiniteXyy commented Jun 14, 2022

This PR contains 3 dev improvements and fixes (Without any code base update)

  1. I found that the existing dev server config for is not working for webpack 5. Since the playground is just a simple web project, I repleace webpack with vite to make dev working flow faster and simpler.
  2. update CI node version to 16
  3. There is something wrong with the Unit test code, the fake timer was inited twice, which will raise an error in newer version of Sinon.
    const timer = Sinon.useFakeTimers()
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #1019 (a17e604) into master (6045af9) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a17e604 differs from pull request most recent head 0dddab5. Consider uploading reports for the commit 0dddab5 to get more accurate results

@@ Coverage Diff @@ ## master #1019 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 2 2 Lines 51 57 +6 Branches 6 5 -1 ========================================= + Hits 51 57 +6 
Impacted Files Coverage Δ
src/use-event-callback.ts 100.00% <100.00%> (ø)
src/use-observable.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29721bf...0dddab5. Read the comment docs.

@InfiniteXyy InfiniteXyy mentioned this pull request Jun 14, 2022
@Miloas Miloas merged commit ea4aca7 into LeetCode-OpenSource:master Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants