LL-106 Reads aggregations from secondary. #1095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ht2 reviewed Jan 18, 2018
Contributor
There was a problem hiding this comment.
So my main concern is that without a separate secondary connection to the collection, I don't believe we can just set the read preference "on the fly". This issue goes into this:
In the mongo CLI shell, we have to specify the read preference as part of our initial connection (or as the first thing we ever do) in order for it to "stick"
If you connect as readPrefernce: 'primary' (defaullt) to begin with, then I think thats what it will simply use.
Contributor
| Needs testing by setting debug flag in mongoose and checking which server the queries are actually hitting! |
Member Author
| Yeah it's on my list. |
ht2 changed the title Contributor
| Confirmed working on Atlas |
ht2 pushed a commit that referenced this pull request Mar 22, 2018
* feat(aggregation): Reads aggregations from secondary. (#1095) * feat(security): Restrict password changing to site admins Also allow users to change their own passwords * perf(webpack): Webpack 3 (#1094) * Webpack 3 * perf: HardSource caching and updated to webpack 3.10 * Added default shareable dashboard. * Added shareable dashboards down migration. * fix: proptypes on shareable dashboards * Add preview button to shareable modellist item * fix: Migration for shareable dashboards * test: Increase timeout time in API test * Update http-test.js * test: Add timeout to test
ht2 pushed a commit that referenced this pull request Mar 22, 2018
* Started adding multiple links for shareable dashboards. * Nested dashboard filters. * Start of the sharable dashboards accordion. * Changed shareable dashboards to a accordion list. * Added delete button to shareable dashboards. * Dashboard shareable link now shows url. * Moved dashboard accordion state to redux * Dashboard page now updates with the expanded accordion dashboard. * Fixed linting errors, removed unused code. * Linting errors. * Linting error. * Fixed tests. * Fixed tests. * Shareable dashboards now authenticate the filter correctly. * Fixed tests. * Fixed shareable dashboard not working with a filter. * Fixed ModelList not working correctly. * Added spinner if dashboard hasn't loaded. * Added organisation to authInfo for dashboards. * fix: Ensure default payoad on token * Added default shareable dashboard. (#1123) * feat(aggregation): Reads aggregations from secondary. (#1095) * feat(security): Restrict password changing to site admins Also allow users to change their own passwords * perf(webpack): Webpack 3 (#1094) * Webpack 3 * perf: HardSource caching and updated to webpack 3.10 * Added default shareable dashboard. * Added shareable dashboards down migration. * fix: proptypes on shareable dashboards * Add preview button to shareable modellist item * fix: Migration for shareable dashboards * test: Increase timeout time in API test * Update http-test.js * test: Add timeout to test * Update index.js * Update index.js
ht2 added a commit that referenced this pull request Apr 18, 2018
### Added - Multiple shareable links per dashboard (#1096) - Requires migration to be run - `yarn migrate` - Aggregations now can read from secondary members on replica set (#1095) - Sentinel Redis support (#1119) - New role to allow organisation creation (via site admin) (#1110) - Widgets now auto pick visualisation name when populated (#1126) ### Security - Passwords can only be changed for the user logged in or by site admins (#1112) ### Fixes - Unicode data now pulled from dependency (#1125) - Ensure order on personaIdentifier IFI values (fixes issue with multiple personaIdents for the same actor) (#1120) - Fix for personaIdentifier migration - Client can select more than 10 xAPI stores (#1130) - Server side validation of Statement Forward queries (#1138) - Statement forwards decode `&46;` in statement keys (#1134) - Fixed issue with hanging file imports on persona data (#1141) - Switch to `clamdscan` as primary AV scanner (#1141) - Requires updated .env settings - refer to .env.example ### Performance and build - Webpack 3 - improved build speed (#1094) ### Migrations **This update requires a migration which can be run using `yarn migrate`.**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.