Skip to content

Conversation

pinanks
Copy link
Contributor

@pinanks pinanks commented Nov 23, 2023

No description provided.

js/package.json Outdated
},
"keywords": [],
"author": "",
"license": "ISC"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty package.json , if not required now, lets remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@@ -0,0 +1,34 @@
import { createLogger, transports, format, config } from 'winston'
import chalk from 'chalk'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pinanks why we are not using logger package, or sdk logger

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sushobhit-lt there's no need to create a separate logger package, it will be a part of sdk-utils itself

"author": "",
"license": "ISC",
"dependencies": {
"@lambdatest/sdk-utils": "workspace:^"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workspace will work at market place as well ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

* Need to update it later so that releases for different languages is triggered based on tag
@pinanks pinanks closed this Nov 25, 2023
sushobhit-lt pushed a commit that referenced this pull request May 1, 2025
…ails Smart Test Flow - URL Tracking plugin for Playwright
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants