New monstro icons #4943
Merged
New monstro icons #4943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This is being done for two reasons: 1. The new Monstro icons (and the icons for Microwave when it's finished) are too large. 2. All ComboBoxes (subjectively) look much nicer this way.
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
New monstro icons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
So, with help of @douglasdgi we solved the problem for make icons that were larger than default size fit the dropdown menus anyway. This was done applying a minor change to the combobox arrows, but keeping in mind it would have affected also other dropdown boxes.
This was made to give Monstro new cooler waveforms icons as i mention in #4940 (so that you can now close it) and also for the new upcoming plugin Microwave that'll use that icons as well.
Here's a before/after the combobox changes
Before:
After:
And also of Monstro as well
Before(Left) - After(Right)
Let me know if you find any issues