Skip to content

Conversation

@PhysSong
Copy link
Member

Fixes #3861 (comment).
To reproduce on any platforms:

  1. Double-click any FX channel
  2. Press Alt + Tab while text is selected
  3. Back to LMMS
@PhysSong PhysSong changed the title Deselect FX channels' name text when it lose focus Deselect FX channels' name text when it loses focus Apr 13, 2018
@PhysSong PhysSong changed the title Deselect FX channels' name text when it loses focus Deselect FX channels' name text when losing focus Apr 13, 2018
@husamalhomsi
Copy link
Member

husamalhomsi commented Apr 14, 2018

This actually fixes all the bugs in #3861.

@PhysSong
Copy link
Member Author

@Sawuare Which version of Qt did you use when testing this? Here's a build with Qt 5.4.2, which is currently used for official releases.
https://github.com/PhysSong/lmms/releases/download/vdummy/lmms-1.2.0-rc5.49-win64.exe

@husamalhomsi
Copy link
Member

husamalhomsi commented Apr 15, 2018

@PhysSong I used Qt 5.10.1. The bugs aren't fixed with Qt 5.4.2.

@husamalhomsi
Copy link
Member

This doesn't fix #3861 (comment) on Windows. The master mixer channel remains selected.

@PhysSong
Copy link
Member Author

Okay. It seems like Qt 5.4.2 have some bugs with QLineEdit::editingFinished signal on some system. Unfortunately, this pull request can't work around the bug.

@PhysSong
Copy link
Member Author

PhysSong commented Jun 2, 2018

I'll merge this one and leave #3861 open.

@PhysSong PhysSong merged commit a9b5b92 into LMMS:stable-1.2 Jun 3, 2018
@PhysSong PhysSong deleted the fxdeselect branch June 3, 2018 12:35
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants