Change selected notes color #4243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I like it. More visible difference Good job! |
zonkmachine approved these changes Mar 14, 2018
| How does the bar look when the transparency is changed? (Change velocity and pan) …On Wed 14 Mar, 2018, 21:12 Oskar Wallgren, ***@***.***> wrote: ***@***.**** approved this pull request. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4243 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIoMgIRmkJDXjAPvohU4DgaoCyQKqy-gks5teTpIgaJpZM4Snfnb> . |
Contributor
| Merge? |
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #4111
Before:
After:
I tested this with http://www.color-blindness.com/coblis-color-blindness-simulator/ and it seems to provide sufficient contrast for color blind people.
@raindropsfromsky @musikBear