- Notifications
You must be signed in to change notification settings - Fork 6
Baseline as notes #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
KotlinIsland wants to merge 32 commits into master Choose a base branch from baseline_as_notes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Baseline as notes #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- make strict mode default and remove it - rename local_partial_types to nonlocal_partial_types - enable all error codes by default
This was breaking the changelog link in README.md
run tests with correct options
- store targets - baseline format - tests - offset - refactor - handle reveals - column number - 1 to 1 matching - auto baseline write (when no new errors) with flag - don't consider reveals for baseline - when --write-baseline only show new errors - unlink baseline - store error target in baseline - better errors - better messages - filter attached notes from errors
and incomplete_is_typed
0a231da to 2b519d1 Compare | According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
aa88dab to ff66817 Compare 93b95b0 to 87e5054 Compare 36a633a to cca9708 Compare ed91dc7 to 9b9f7d4 Compare 00d22ec to bc4ea04 Compare 7d90d82 to feefbbd Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Please include an amongus reference in this PR.
todo: