Delegate Int|Short|Long.reverseBytes to Java Stdlib #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Seems like JVM's JIT compiler can't pattern match bytes reversal, so it's worth explicitly delegating to Java Stdlib functions, that are intrinsics candidates. For long values, the new implementation shows 20% perf improvement for reversal itself. Functions depending on it, like readXXXLe or writeXXXLe also show some moderate performance improvement from the change.
shanshin approved these changes Nov 19, 2024
Contributor
shanshin left a comment
shanshin left a comment There was a problem hiding this comment.
A good improvement for integers!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Seems like JVM's JIT compiler can't pattern match bytes reversal, so it's worth explicitly delegating to Java Stdlib functions, that are intrinsics candidates.
For long values, the new implementation shows 20% perf improvement for reversal itself.
Functions depending on it, like readXXXLe or writeXXXLe also show some moderate performance improvement from the change: