Skip to content

Fixed flaky jsonWrite test #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fixed flaky jsonWrite test #873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions tests/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/Write.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class Write : TestBase() {
csvStr shouldStartWith """
name;age;city;weight;isHappy
"{""firstName"":""Alice"",""lastName"":""Cooper""}";15;London;54;true
""".rejoinWithSystemLineSeparator()
""".trimIndent().lines().joinToString(System.lineSeparator())
}

@Test
Expand All @@ -73,7 +73,7 @@ class Write : TestBase() {
"city": "London",
"weight": 54,
"isHappy": true
""".rejoinWithSystemLineSeparator()
""".trimIndent()
}

@Test
Expand Down Expand Up @@ -215,7 +215,7 @@ class Write : TestBase() {
// Specify mismatch subscriber
mismatchSubscriber = writeMismatchMessage,

).use { writer: ArrowWriter ->
).use { writer: ArrowWriter ->

// Save to any format and sink, like in the previous example
writer.writeArrowFeather(file)
Expand All @@ -241,10 +241,6 @@ class Write : TestBase() {
}

companion object {
private fun String.rejoinWithSystemLineSeparator() = rejoinWithLineSeparator(System.lineSeparator())

private fun String.rejoinWithLineSeparator(separator: String) = trimIndent().lines().joinToString(separator)

private fun useTempFile(action: (File) -> Unit) {
val file = kotlin.io.path.createTempFile("dataframeWriteTest")
action(file.toFile())
Expand Down
Loading