Small convertTo fix #800
Merged
Small convertTo fix #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…enabled. Updated contribution guide too. TC will have to be updated manually
…-nullable column with nulls in it. This is now avoided and the behavior has been simplified/stabilized
# Conflicts: # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/columns/DataColumnImpl.kt
…ary non-nullable column with nulls in it. This is now avoided and the behavior has been simplified/stabilized
zaleslaw reviewed Jul 31, 2024
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/convertTo.kt Show resolved Hide resolved
zaleslaw reviewed Jul 31, 2024
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/convertTo.kt Show resolved Hide resolved
zaleslaw reviewed Jul 31, 2024
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/schema/Utils.kt Show resolved Hide resolved
zaleslaw requested changes Jul 31, 2024
|
| Interestingly, adding kotlinLogging breaks the compiler plugin in the black box tests wherever it is used with: @koperagen can we add this dependency to the plugin too? |
zaleslaw approved these changes Jul 31, 2024
| Generated sources will be updated after merging this PR. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
With the debug mode enabled, one failing test of #713 was in
convertTo.It likely didn't cause any user issues, but it could prevent #712, so best to solve it.
It was a relatively small fix. I renamed
createEmptyColumntocreateNullFilledColumnas that better reflects is behavior. Then, instead of creating the erroneous column, it throws an exception. This eliminates the need for the large boolean check in theconvertToImplfunction. Finally, sinceupdatecannot target non-existing columns, I needed to update thefilloption ofconvertTo, toupdateoraddcolumns depending on whether they were there already or not.