Fixing numerical types #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Extended the handling of SQL Types TINYINT and SMALLINT in PostgreSql.kt to address issues reported against these data types.
…Name` as a new property. Also made changes to handle TINYINT and SMALLINT types more effectively in MySql and MariaDb classes.
…ral SQL related classes.
Jolanrensen reviewed Jan 2, 2024
| get() = "org.mariadb.jdbc.Driver" | ||
| | ||
| override fun convertSqlTypeToColumnSchemaValue(tableColumnMetadata: TableColumnMetadata): ColumnSchema? { | ||
| if(tableColumnMetadata.sqlTypeName == "SMALLINT") { |
| @zaleslaw don't forget to merge it in the master too |
zaleslaw added a commit that referenced this pull request Jan 3, 2024
* Update handling of SQL Types in PostgreSQL and add test cases Extended the handling of SQL Types TINYINT and SMALLINT in PostgreSql.kt to address issues reported against these data types. * Continued the enhancement of TableColumnMetadata by adding `javaClassName` as a new property. Also made changes to handle TINYINT and SMALLINT types more effectively in MySql and MariaDb classes. * Refactor type handling of TINYINT and SMALLINT in SQL classes * In this commit, TINYINT and SMALLINT types are refactored across several SQL related classes. * Remove unnecessary imports and add ignore annotations to tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.