Static notebook fixes and examples #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Jolanrensen force-pushed the static-examples2 branch from 2f1b98b to 47723fc Compare 
| Now I'll just have to redo everything when #513 is done |
| And cherry picked into 0.12.1 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #503 and #476.
This PR adds static HTML DataFrames to .ipynb files, both when rendering DataFrames in Swing and HTML such that they can be displayed on Github. For example: https://github.com/Kotlin/dataframe/blob/static-examples2/examples/notebooks/github/github.ipynb
At the moment, I excluded the
jsonexample because enabling static output makes the file 170MB+ and thus too large for GitHub. This probably needs #512 to be fixed beforehand.Non-JS collapsible DataFrames also should be explored later: #513.