-   Notifications  
You must be signed in to change notification settings  - Fork 76
 
Gather kdocs #1272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
   Merged  
     Merged  
 Gather kdocs #1272
Conversation
   This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters   
       Jolanrensen  reviewed   Jun 26, 2025    
     core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/gather.kt  Outdated   Show resolved Hide resolved  
   Jolanrensen  reviewed   Jun 26, 2025    
     core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/gather.kt  Outdated   Show resolved Hide resolved  
   Jolanrensen  reviewed   Jun 26, 2025    
    Jolanrensen  reviewed   Jun 26, 2025    
    Jolanrensen  reviewed   Jun 26, 2025    
     core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/gather.kt  Outdated   Show resolved Hide resolved  
   Jolanrensen  reviewed   Jun 26, 2025    
     core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/gather.kt  Outdated   Show resolved Hide resolved  
   Jolanrensen  reviewed   Jun 26, 2025    
     core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/gather.kt  Outdated   Show resolved Hide resolved  
   Jolanrensen  reviewed   Jun 26, 2025    
     core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/gather.kt  Outdated   Show resolved Hide resolved  
   Jolanrensen  reviewed   Jun 26, 2025    
     core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/gather.kt  Outdated   Show resolved Hide resolved  
   Jolanrensen  reviewed   Jun 26, 2025    
    Jolanrensen  reviewed   Jun 26, 2025    
  |   really good! Just some small notes  |  
  Jolanrensen  approved these changes   Jun 27, 2025    
  There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one unused interface, otherwise good
| */ | ||
| @Suppress("ClassName") | ||
| @ExcludeFromSources | ||
| interface GATHER_OPERATION | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed
# Conflicts: # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentation/DocumentationUrls.kt
 Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment 
  Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.    
 
Close #815.