Added tableTypes argument to readAllSqlTables #1270
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In other databases like DuckDB, this type is actually "BASE TABLE" instead of "TABLE", making the function return 0 results. Setting it to `null` makes the integration do its default behavior, which usually is no filtering at all.
| Okay this breaks on PostgreSQL. We need the types argument, but it should be customizable at least |
…l error when no tables are found, hinting at the tableTypes argument and what the database supports
Jolanrensen changed the title tableTypes argument to readAllSqlTables | Adjusted it to include the |
Closed
| @zaleslaw Alternatively, we could allow customizing tableType filters, but then the default would be |
| See #1283 for an alternative approach |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #1282
In other databases like DuckDB, this type is actually "BASE TABLE" instead of "TABLE", making the function return 0 results. Setting it to
nullmakes the integration do its default behavior, which usually is no filtering at all.