Deephaven csv as default #1057
Deephaven csv as default #1057
Conversation
Jolanrensen force-pushed the deephaven-csv-default branch from 50ce472 to 4004b65 Compare Jolanrensen force-pushed the deephaven-csv-default branch 7 times, most recently from 3496cb7 to d6fe324 Compare Jolanrensen force-pushed the deephaven-csv-default branch from 8b8bb80 to 9a87d0e Compare Jolanrensen force-pushed the deephaven-csv-default branch from 79d771d to b24db62 Compare Jolanrensen force-pushed the deephaven-csv-default branch from 43f191d to 6055995 Compare 
dataframe-csv/src/test/kotlin/org/jetbrains/kotlinx/dataframe/io/DelimCsvTsvTests.kt Show resolved Hide resolved
| | ||
| // if the user adds the dataframe-csv module, this will override old CSV reading method in DataFrame.read() | ||
| override val testOrder: Int = CSV().testOrder - 1 | ||
| override val testOrder: Int = 20_000 |
There was a problem hiding this comment.
This is the test order for guess.kt, so the order in which DataFrame.read() tries the supported formats. CSV used to have 20,000, so now the new one gets the same order number.
| * They'll hopefully be faster and better._ | ||
| * | ||
| * @param file The file to read. Can also be compressed as `.gz` or `.zip`, see [Compression][org.jetbrains.kotlinx.dataframe.io.Compression]. | ||
| * @param file The file to read. Can also be compressed as `.gz` or `.zip`, see [Compression]. |
There was a problem hiding this comment.
Is it navigable correctly for now?
There was a problem hiding this comment.
it may not be, good catch! KoDEx is not good at redirecting references/paths outside the current module.
| ).convert("col2").toStr() | ||
| | ||
| val str = StringWriter() | ||
| df.writeCSV(str) |
There was a problem hiding this comment.
Sorry, where all these tests (with this logic) was moved or adopted for the Deephaven csv?
There was a problem hiding this comment.
exactly, it's in DelimCsvTsvTests in dataframe-csv
| | ||
| internal const val WRITE_CSV = | ||
| "The writeCSV() functions are deprecated in favor of writeCsv() in dataframe-csv. $MESSAGE_0_17" | ||
| internal const val WRITE_CSV_IMPORT = "org.jetbrains.kotlinx.dataframe.io.writeCsv" |
| charset, | ||
| ) | ||
| } | ||
| ): DataFrame<*> = error(DF_READ_NO_CSV) |
There was a problem hiding this comment.
is it true, that it will be not possible to read from remote endpoint the csv with new parser? Or am I wrong?
There was a problem hiding this comment.
No you still can, no problem. By URL, or String. It's tested in the dataframe-csv module.
There was a problem hiding this comment.
This function is DataFrame.read() that weird overload that we deprecated already some time ago.
Jolanrensen force-pushed the deephaven-csv-default branch 2 times, most recently from 162f248 to d32cbb9 Compare Jolanrensen force-pushed the deephaven-csv-default branch from d32cbb9 to 1e2bb06 Compare 
Fixes #1047
Works to finish #827
DataFrame.read()functions@Importis gonna be experimental anyway. The only reason the old csv integration still has compiler plugin support is to use it as example for the new csv integration later.testImplementation(project(":dataframe-csv"))to :core until we split off jupyter and merge sample.api tests