feat(*): add http/https proxy support for service request #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
windmgc force-pushed the feat-proxy-support branch from 99bd94e to 89bc591 Compare 
fffonion approved these changes Aug 7, 2023
ttyS0e pushed a commit to KongHQ-CX/lua-resty-aws that referenced this pull request Oct 2, 2023
This PR adds support for using HTTP/HTTPS proxy on service requests. Proxies that are defined in the environment variable will also take effect, to keep aligned with https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-proxy.html Note that most of the credential fetch-related requests (except the one that hit STS) will not use this proxy deliberately, as I thought it is very rare for those environment-related requests to have a need to use proxy KAG-1621 FTI-5242
ttyS0e pushed a commit to KongHQ-CX/lua-resty-aws that referenced this pull request Oct 2, 2023
This PR adds support for using HTTP/HTTPS proxy on service requests. Proxies that are defined in the environment variable will also take effect, to keep aligned with https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-proxy.html Note that most of the credential fetch-related requests (except the one that hit STS) will not use this proxy deliberately, as I thought it is very rare for those environment-related requests to have a need to use proxy KAG-1621 FTI-5242
ttyS0e pushed a commit to KongHQ-CX/lua-resty-aws that referenced this pull request Oct 2, 2023
This PR adds support for using HTTP/HTTPS proxy on service requests. Proxies that are defined in the environment variable will also take effect, to keep aligned with https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-proxy.html Note that most of the credential fetch-related requests (except the one that hit STS) will not use this proxy deliberately, as I thought it is very rare for those environment-related requests to have a need to use proxy KAG-1621 FTI-5242
ttyS0e pushed a commit to KongHQ-CX/lua-resty-aws that referenced this pull request Oct 3, 2023
This PR adds support for using HTTP/HTTPS proxy on service requests. Proxies that are defined in the environment variable will also take effect, to keep aligned with https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-proxy.html Note that most of the credential fetch-related requests (except the one that hit STS) will not use this proxy deliberately, as I thought it is very rare for those environment-related requests to have a need to use proxy KAG-1621 FTI-5242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for using HTTP/HTTPS proxy on service requests. Proxies that are defined in the environment variable will also take effect, to keep aligned with https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-proxy.html
Note that most of the credential fetch-related requests (except the one that hit STS) will not use this proxy deliberately, as I thought it is very rare for those environment-related requests to have a need to use proxy
KAG-1621
FTI-5242
#2